feat: allow specifying search parameters in the URL#38288
feat: allow specifying search parameters in the URL#38288waldyrious wants to merge 1 commit intoopenedx:masterfrom
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @waldyrious! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Read facet filters (language, org, topic, etc.) from URL query params and update the browser address bar after each search or filter change so the URL always reflects the current filters. This allows searches to be shared or bookmarked via URLs like /courses?search_query=foo&language=pt
waldyrious
force-pushed
the
allow-search-via-url-params
branch
from
0236a2c to
68f72a7
Compare
|
Hi @waldyrious! Welcome, and thank you for your contribution! We have received your CLA form, and have sent you the completed form for signature via Docusign. Please check your email (and spam mail) to make sure you receive it. Thanks! |
mphilbrick211
moved this from Needs Triage
to Needs Tests Run or CLA Signed
in Contributions
mphilbrick211
added
the
needs test run
|
I got the document, @mphilbrick211, thanks! I've just signed it. |
3 participants
Description
This patch implements reading search facet filters (language, org, topic, etc.) from URL query parameters, and updating the browser address bar to reflect changes to search terms or filters, so the URL always reflects the current filters.
This allows searches to be shared or bookmarked via URLs like
/courses?search_query=foo&language=pt.It also adds an additional confirmation to the user about which filters are currently applied.
Supporting information
I didn't find previous discussions or requests for this feature.
Testing instructions
Unit tests have been added to cover the added behavior.
Other information
For additional context, this change was motivated by me trying to bookmark a search in WikiLearn, so that I could periodically revisit it to check out any new courses matching my preferences, or share a search results page with someone who might be interested in that specific set of courses.